fix: imports and exports follows type-only #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Feb 6, 2025
|
If a new version is to be released, I would suggest an rc version. 🤔 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #311
I've been working on an approach that might seem a bit unconventional and wondering if you could review and provide feedback on these implementation details:
Preprocessing source code by renaming and adding type aliases to preserve import/export variable type information in variable names
Restoring import/export variable type information in the
renderChunkphase based on the variable names containing type informationWould love to hear your thoughts on potential improvements or simpler alternatives.
Are there any concerns or better approaches you can suggest?